[tor-bugs] #27324 [Core Tor/Tor]: Rework AUTHENTICATE cell parsing and remaining generation with trunnel (was: Rework AUTHENTICATE cell parsing with trunnel)

[Tor Bug Tracker & Wiki]

#27324: Rework AUTHENTICATE cell parsing and remaining generation with trunnel
-------------------------------------------------+-------------------------
 Reporter:  rl1987                               |          Owner:  rl1987
     Type:  enhancement                          |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  trunnel wireformat heartbleed-       |  Actual Points:
  safety security parsing                        |
Parent ID:  #27143                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Description changed by rl1987:

Old description:

> In channetls.c we have `channel_tls_process_authenticate_cell()` that
> uses memcpy et. al. to parse AUTHENTICATE cell. This should be done with
> machine generated code from trunnel. Generation is mostly implemented
> with trunnel already.

New description:

 In channetls.c we have `channel_tls_process_authenticate_cell()` that uses
 memcpy et. al. to parse AUTHENTICATE cell. This should be done with
 machine generated code from trunnel. We also should rely more on trunnel
 when generating AUTHENTICATE cells. Generation of Type 1 authentication
 payload is mostly implemented with trunnel already.

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27324#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online