[tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

[Tor Bug Tracker & Wiki]

#28633: Pad on specific circuit purposes + ltups
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding                                        |
Parent ID:  #28632                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Code LGTM but the bitmask logic is non-trivial. Let's close this ticket
 after we get some unittests as well.

 I'm also wondering if we should test that `CIRCUIT_PURPOSE_MAX_` is less
 than 32 (which is the max state we can encode in the 32-bit bitfield).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28633#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online