[tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Dec 10 09:37:34 UTC 2018
#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201812, | Actual Points:
GeorgKoppen201812, boklm201811 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):
* keywords: tbb-rbm, TorBrowserTeam201812R, GeorgKoppen201812, boklm201811
=> tbb-rbm, TorBrowserTeam201812, GeorgKoppen201812, boklm201811
* status: needs_review => needs_revision
Comment:
Replying to [comment:10 gk]:
> See: `bug_25779_v4` (https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_25779_v4&id=54f63e3176ec840e37c283689746b2a0cb419f8c)
in my public repo for a patch.
I think we can simplify a little by defining some option like this:
{{{
diff --git a/projects/tor/config b/projects/tor/config
index 4ba18d9..7fba7d0 100644
--- a/projects/tor/config
+++ b/projects/tor/config
@@ -21,6 +21,8 @@ targets:
version: '[% c("abbrev") %]'
git_hash: master
tag_gpg_id: 0
+ var:
+ tor_rust: '[% c("var/linux") || c("var/osx") %]'
linux:
var:
}}}
And then replacing the various tests using `(c("var/linux") ||
c("var/osx")) && c("var/nightly")` by `c("var/tor_rust")`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25779#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list