[tor-bugs] #28752 [Applications/Tor Browser]: Gradle sometimes downloads tor-android-binary resources during build (or the build is failing)

[Tor Bug Tracker & Wiki]

#28752: Gradle sometimes downloads tor-android-binary resources during build (or
the build is failing)
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam201812                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:2 sisbell]:
 > Gradle offline is flagged so it shouldn't download anything (although
 there can always be a bug in gradle). It could be that the files are not
 actually downloading even though the logs say it is attempting download.
 Did the build say it was downloading and then pass the build. Or did it
 say it was downloading and then fail the build?

 It says it was downloading
 {{{
 26:02.41
 :geckoview:compileOfficialWithGeckoBinariesNoMinApiReleaseJavaWithJavac
 26:02.43 Download
 https://raw.githubusercontent.com/guardianproject/gpmaven/master/org/torproject
 /tor-android-binary/0.3.4.9/tor-android-binary-0.3.4.9.pom
 26:04.40 Download
 https://raw.githubusercontent.com/guardianproject/gpmaven/master/org/torproject
 /tor-android-binary/0.3.4.9/tor-android-binary-0.3.4.9.aar
 26:04.91
 :app:generateOfficialWithoutGeckoBinariesNoMinApiPhotonDebugAndroidTestResValues
 }}}
 and then the build passed. My guess is that in the rare cases I saw the
 build failures this resulted in the download failing for some reason. And
 later on the missing dependencies were not available.

 The big question is why it is downloading those things and just those two
 even though we bundled everything.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28752#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online