[tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

Mon Dec 3 03:00:38 UTC 2018

#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328                           |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by neel):

 * status:  needs_revision => needs_review

Comment:

 I have added the needed changes to `fascist_firewall_choose_address_ls()`.

 I have also added the new warnings to `hs_get_extend_info_from_lspecs()`
 and added a test for the missing legacy ID as the last commit. The
 unreachable IP address warning is untested for now.

 Setting as needs review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:69>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online