[tor-bugs] #27373 [Core Tor/Tor]: add UTF-8 validation code

[Tor Bug Tracker & Wiki]

#27373: add UTF-8 validation code
---------------------------------+------------------------------------
 Reporter:  cyberpunks           |          Owner:  (none)
     Type:  task                 |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  Tor: 0.3.6.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  rust-wants, prop285  |  Actual Points:
Parent ID:  #24033               |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------

Comment (by teor):

 Also, clang does partial validation of unicode strings:
 {{{
 src/test/test_util.c:4044:38: error: invalid universal character
   tt_int_op(0, OP_EQ, validate_utf8("\U00110000", 5));
                                      ^~~~~~~~~~
 ./src/ext/tinytest_macros.h:158:24: note: expanded from macro 'tt_int_op'
         tt_assert_test_type(a,b,#a" "#op" "#b,long,(val1_ op val2_), \
                               ^
 ./src/ext/tinytest_macros.h:144:28: note: expanded from macro
       'tt_assert_test_type'
         tt_assert_test_fmt_type(a,b,str_test,type,test,type,fmt,        \
                                   ^
 ./src/ext/tinytest_macros.h:117:16: note: expanded from macro
       'tt_assert_test_fmt_type'
         type val2_ = (b);                                               \
                       ^
 1 error generated.
 make: *** [src/test/src_test_test-test_util.o] Error 1
 make: *** Waiting for unfinished jobs....
 }}}
 https://travis-ci.org/teor2345/tor/jobs/421941943#L3884

 (The macOS gcc builds fail as well, but that's because gcc is an alias to
 clang on those systems. I'll fix that in #27252.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27373#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online