[tor-bugs] #25573 [Core Tor/Tor]: Track half-closed stream IDs

[Tor Bug Tracker & Wiki]

#25573: Track half-closed stream IDs
------------------------------------------------+--------------------------
 Reporter:  mikeperry                           |          Owner:  (none)
     Type:  defect                              |         Status:
                                                |  needs_review
 Priority:  Medium                              |      Milestone:  Tor:
                                                |  0.3.4.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  guard-discovery-stats 034-backport  |  Actual Points:
Parent ID:  #25574                              |         Points:
 Reviewer:  teor                                |        Sponsor:
                                                |  SponsorV-can
------------------------------------------------+--------------------------

Comment (by mikeperry):

 Ok I also decided to go ahead and sort the list of half-closed
 connections, so we can bsearch them on the common operations of cell
 arrival, and also guard against duplicate stream ids. I added tests for
 duplicates and list management correctness as well. These are additional
 commits on each branch (the pull request with the fixups from the first
 review, and also as separate commits on top of
 mikeperry/ticket25573-v2-squashed).

 When we think this is merge-ready, I can do the rebase dance so we
 actually merge to master, but I'd still like to avoid doing that until
 we're sure we like it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25573#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online