[tor-bugs] #27191 [Core Tor/Tor]: handling double spaces in protover

[Tor Bug Tracker & Wiki]

#27191: handling double spaces in protover
--------------------------+------------------------------------
 Reporter:  cyberpunks    |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  rust          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_review


Comment:

 Replying to [comment:1 cyberpunks]:
 > The protospaces2 branch at ​​https://gitgud.io/onionk/tor.git changes
 the C implementation to reject them. Nothing actually produces extra
 spaces like this, right?

 Extra spaces are not allowed by the protover spec. Each separator is
 exactly one space:
 https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n780

 But we should run `make test-network-all` using
 [https://gitweb.torproject.org/chutney.git chutney] to make sure that
 standard tor clients aren't inserting extra spaces.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27191#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online