[tor-bugs] #27177 [Core Tor/Tor]: rust protover accepts tabs and newlines in protocol versions

[Tor Bug Tracker & Wiki]

#27177: rust protover accepts tabs and newlines in protocol versions
--------------------------------------------+------------------------------
 Reporter:  cyberpunks                      |          Owner:  (none)
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Medium                          |      Milestone:  Tor:
                                            |  0.3.5.x-final
Component:  Core Tor/Tor                    |        Version:  Tor: 0.3.3.9
 Severity:  Normal                          |     Resolution:
 Keywords:  rust,033-backport,034-backport  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by teor):

 * status:  new => needs_revision
 * milestone:   => Tor: 0.3.5.x-final


Comment:

 Thanks for this patch, it looks good to me.

 Here's what needs to change before it merges:
 * code changes need a changes file that passes `make check-changes`
   * (doc and comment changes don't get a changes file)
 * the branch needs to be rebased onto maint-0.3.3

 Let us know if you don't want to make these changes, and someone else will
 do them eventually.

 And also:
 * we need to wait for the CI to pass:
   * I have pushed your branches to my github, which is set up to run
 travis
   * https://travis-ci.org/teor2345/tor/builds/417209205
   * if you want to run travis automatically, you can configure it on
 gitgud, or submit a pull request to https://github.com/torproject/tor

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27177#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online