[tor-bugs] #26826 [Applications/Tor Browser]: TBA - Does the app need the SYSTEM_ALERT_WINDOW permission?

[Tor Bug Tracker & Wiki]

#26826: TBA - Does the app need the SYSTEM_ALERT_WINDOW permission?
-----------------------------------------------+---------------------------
 Reporter:  sysrqb                             |          Owner:  tbb-team
     Type:  task                               |         Status:
                                               |  needs_review
 Priority:  High                               |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201808R  |  Actual Points:
Parent ID:  #24796                             |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by sysrqb):

 * keywords:  tbb-mobile => tbb-mobile, TorBrowserTeam201808R
 * status:  new => needs_review


Comment:

 I'm open to discussing this, but I created a branch for deleting this.
 This patch permanently disables (sets selectable=false) the tab queue, as
 well - the tab queue should not be enabled if the app doesn't have the
 SYSTEM_ALERT_WINDOW permission. We can delete the Settings entry for the
 tab queue, as well - if that is preferred.

 Branch `26826`.

 For reference:
 https://developer.android.com/reference/android/Manifest.permission.html#SYSTEM_ALERT_WINDOW

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26826#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online