[tor-bugs] #25852 [Core Tor/Tor]: GETINFO exit-policy for tor client should return 551

[Tor Bug Tracker & Wiki]

#25852: GETINFO exit-policy for tor client should return 551
--------------------------------------------+------------------------------
 Reporter:  dmr                             |          Owner:  (none)
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Medium                          |      Milestone:  Tor:
                                            |  0.3.4.x-final
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tor-spec, tor-client, fast-fix  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:  dgoulet                         |        Sponsor:
--------------------------------------------+------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:2 rl1987]:
 > * https://github.com/rl1987/tor/compare/bug25852

 Hmmmm so I'm wondering. So `router_get_my_routerinfo()` does return NULL
 if we aren't in `server_mode()` but it also returns NULL if the rebuild
 failed.

 So we could be in "server mode" but just unable to create a descriptor for
 some reasons... Thus what I propose is that if `!server_mode()` then we
 should be sending back "Not running in server mode" but if we are but
 `router_get_my_routerinfo()` returns NULL, we should send back "Internal
 error" (which is what getinfo by default will return if the `errmsg` value
 is still NULL).

 > * https://github.com/rl1987/torspec/compare/bug25852

 lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25852#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online