[tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_information
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, boklm201804,                |  Actual Points:
  TorBrowserTeam201804                           |
Parent ID:  #12968                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by boklm):

 Replying to [comment:74 boklm]:
 > When building using binutils 2.27, the files that are different are:
 > {{{
 > Browser/firefox.exe
 > Browser/lgpllibs.dll
 > Browser/libEGL.dll
 > Browser/libGLESv2.dll
 > Browser/mozglue.dll
 > Browser/plugin-container.exe
 > Browser/plugin-hang-ui.exe
 > Browser/TorBrowser/Tor/PluggableTransports/fte.cDFA.pyd
 > Browser/updater.exe
 > Browser/xul.dll
 > }}}

 When doing builds with binutils 2.25.1, the list of files that are
 different is the same. So it seems to be caused by some change between
 2.24 and 2.25.1.

 When running `objdump -x` on 2 versions of the same dll file, we have this
 diff:
 {{{
 2,3c2,3
 < 1/libEGL.dll:     file format pei-i386
 < 1/libEGL.dll
 ---
 > 2/libEGL.dll:     file format pei-i386
 > 2/libEGL.dll
 39c39
 < CheckSum              003422cf
 ---
 > CheckSum              00342445
 55c55
 < Entry 5 0032c000 00019b70 Base Relocation Directory [.reloc]
 ---
 > Entry 5 0032c000 00019b74 Base Relocation Directory [.reloc]
 27642,27649c27642,27649
 <       reloc 27130 offset  cc3 [30b13cf4] HIGHLOW
 <       reloc 27131 offset  cd0 [30b13d01] HIGHLOW
 <       reloc 27132 offset  cd7 [30b13d08] HIGHLOW
 <       reloc 27133 offset  d81 [30b13db2] HIGHLOW
 <       reloc 27134 offset  dd2 [30b13e03] HIGHLOW
 <       reloc 27135 offset  dd9 [30b13e0a] HIGHLOW
 <       reloc 27136 offset  de0 [30b13e11] HIGHLOW
 <       reloc 27137 offset  e83 [30b13eb4] HIGHLOW
 ---
 >       reloc 27130 offset  cc2 [30b13cf3] HIGHLOW
 >       reloc 27131 offset  cc9 [30b13cfa] HIGHLOW
 >       reloc 27132 offset  cd0 [30b13d01] HIGHLOW
 >       reloc 27133 offset  d73 [30b13da4] HIGHLOW
 >       reloc 27134 offset  dc3 [30b13df4] HIGHLOW
 >       reloc 27135 offset  dd0 [30b13e01] HIGHLOW
 >       reloc 27136 offset  dd7 [30b13e08] HIGHLOW
 >       reloc 27137 offset  e81 [30b13eb2] HIGHLOW
 30163,30166c30163,30166
 <       reloc 29656 offset  d2f [30b13d60] HIGHLOW
 <       reloc 29657 offset  d42 [30b13d73] HIGHLOW
 <       reloc 29658 offset  dbf [30b13df0] HIGHLOW
 <       reloc 29659 offset  dd2 [30b13e03] HIGHLOW
 ---
 >       reloc 29656 offset  cff [30b13d30] HIGHLOW
 >       reloc 29657 offset  d12 [30b13d43] HIGHLOW
 >       reloc 29658 offset  d8f [30b13dc0] HIGHLOW
 >       reloc 29659 offset  da2 [30b13dd3] HIGHLOW
 36415,36416c36415,36416
 <       reloc 35916 offset  dd2 [30b13e03] HIGHLOW
 <       reloc 35917 offset  dda [30b13e0b] HIGHLOW
 }}}
 Followed by many other reloc lines.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16472#comment:75>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online