[tor-bugs] #25960 [Core Tor/Tor]: Allow additional header lines in bandwidth measurements documents

[Tor Bug Tracker & Wiki]

#25960: Allow additional header lines in bandwidth measurements documents
-------------------------------------------------+-------------------------
 Reporter:  juga                                 |          Owner:  juga
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  bwauth, 029-backport, 031-backport,  |  Actual Points:
  032-backport, 033-backport                     |
Parent ID:  #25925                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  bwauth => bwauth, 029-backport, 031-backport, 032-backport,
     033-backport
 * status:  assigned => needs_revision
 * type:  defect => enhancement
 * milestone:   => Tor: 0.3.4.x-final


Comment:

 Thanks for this patch!

 Here is my review:
 * please base this commit on maint-0.2.9, so we can backport it
 * Travis CI seems to have failed, is it set up on your account? Please
 check #tor-ci on IRC
 * please implement and add unit tests for the two header_ended=0 cases:
   * an incomplete line contains a "bw=" key
   * an incomplete line contains a "node_id=" key
 * please add a unit test for the header_ended=1 case:
   * an incomplete line occurs after the first complete line, please test:
     * a line missing node_id
     * a line missing bw
     * a line missing node_id and bw
 * this log message is confusing, because it contains a double negative,
 "no" and "nor":
 {{{
 +    log_debug(LD_DIRSERV, "No bw nor node_id found in bandwidth file
 line: %s",
 +             escaped(orig_line));
 }}}

 Please use something like:
 {{{
 +    log_debug(LD_DIRSERV, "Missing bw or node_id in bandwidth file line:
 %s",
 +             escaped(orig_line));
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25960#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online