[tor-bugs] #25933 [Core Tor/Tor]: Remove connection_ap_attach_pending(0) from per-second callback.

[Tor Bug Tracker & Wiki]

#25933: Remove connection_ap_attach_pending(0) from per-second callback.
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-roadmap-subtask,                 |  Actual Points:
  034-triage-20180328, 034-included-20180328     |
Parent ID:  #25375                               |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 I believe this is correct.

 We set `untried_pending_connections = 1` just before activating the
 postloop event meaning we will pass over the pending connections soon
 after.

 lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25933#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online