[tor-bugs] #25901 [Core Tor/Tor]: hs-v3: Memleak on SIGHUP

[Tor Bug Tracker & Wiki]

#25901: hs-v3: Memleak on SIGHUP
-------------------------+-------------------------------------------------
     Reporter:  dgoulet  |      Owner:  dgoulet
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  tor-hs, 032-backport, 033-backport,
     Severity:  Normal   |  memleak, fast-fix
Actual Points:           |  Parent ID:
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 On SIGHUP, we move the hs state between service objects.

 Because `hs_service_new()` allocates the replaycache by default, we
 overwrite it within `move_hs_state()`:

 {{{
   dst->replay_cache_rend_cookie = src->replay_cache_rend_cookie;
 }}}

 We have to free the `dst` cache before.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25901>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online