[tor-bugs] #25515 [Core Tor/Tor]: Add a unit test for geoip_load_file()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Apr 17 17:08:24 UTC 2018
#25515: Add a unit test for geoip_load_file()
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: isis | Sponsor:
--------------------------+------------------------------------
Comment (by juga):
Thanks for isis for your review and the fixes with the trivial things.
For the less trivial ones, and after nickm, i have removed the FIXME and
the unused variables.
Since your branch is in github, i pushed to github too, you can see the
diff here:
https://github.com/isislovecruft/tor/compare/bug25515...juga0:bug25515_rmunused_vars?diff=split&expand=1&name=bug25515_rmunused_vars
Should i attach the patch here or is it easier to just merge or comment my
branch in github?.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25515#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list