[tor-bugs] #25511 [Core Tor/Tor]: Expose TZ info on control port for better debugging of time errors

[Tor Bug Tracker & Wiki]

#25511: Expose TZ info on control port for better debugging of time errors
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  roadmap, controller, 034-roadmap-    |  Actual Points:
  master, 034-triage-20180328,                   |
  034-included-20180328, s8-errors               |
Parent ID:                                       |         Points:
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:34 neel]:
 > New patch: `b25511-003.patch`.
 >
 > I also mocked `tor_gettimeofday()` here.
 Thanks! I think that's most of what we need.

 A few small changes, and I think we'll be good:
 * `mock_tor_gettimeofday()` can be in src/test/test_controller.c because
 nothing else uses it
 * `mock_tor_gettimeofday()` doesn't have to be declared with `MOCK_DECL()`
 nor defined with `MOCK_IMPL()`; it can be defined as `static` in
 src/test/test_controller.c

 Please feel free to force-push your updated changes to your GitHub pull
 request.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25511#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online