[tor-bugs] #25226 [Core Tor/Tor]: Circuit cell queue can fill up memory

[Tor Bug Tracker & Wiki]

#25226: Circuit cell queue can fill up memory
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-cell, tor-relay, tor-dos,        |  Actual Points:
  033-must, review-group-34, security,           |
  033-triage-20180320, 033-included-20180320     |
Parent ID:                                       |         Points:
 Reviewer:  arma                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 > Branch (with fixup): bug25226_033_01
 > Branch (squashed): bug25226_033_02
 {{{
 #define RELAY_CIRC_CELL_QUEUE_SIZE_MIN CIRCWINDOW_START_MAX
 }}}
 {{{
 /* Default value is set to a large value so we can handle padding cells
  * properly which aren't accounted for in the SENDME window. Default is
 50000
  * allowed cells in the queue resulting in ~25MB. */
 #define RELAY_CIRC_CELL_QUEUE_SIZE_DEFAULT \
   (50 + RELAY_CIRC_CELL_QUEUE_SIZE_MIN)
 }}}

 > (50 **+** RELAY_CIRC_CELL_QUEUE_SIZE_MIN)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25226#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online