[tor-bugs] #25616 [Core Tor/Tor]: Non-fatal assertion in hs_desc_encode_descriptor similar to #24972

[Tor Bug Tracker & Wiki]

#25616: Non-fatal assertion in hs_desc_encode_descriptor similar to #24972
-------------------------------------------------+-------------------------
 Reporter:  alnsn                                |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.10
 Severity:  Normal                               |     Resolution:
 Keywords:  regression, tor-hs, 032-backport,    |  Actual Points:
  033-triage-20180326 033-included-20180326      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * keywords:
     regression, tor-hs, 032-backport, 033-must 033-triage-20180326
     033-included-20180326
     =>
     regression, tor-hs, 032-backport, 033-triage-20180326
     033-included-20180326
 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


Comment:

 Moving this to 034. The fixes aren't simple and could cause possible
 regression because we are quite close from 033 stable.

 The BUG() + log_warn() might annoy some operators in the meantime but at
 least it is harmless as tor does recover from the error gracefully by
 rebuilding the descriptor with synced time source.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25616#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online