[tor-bugs] #23603 [Core Tor/Tor]: hs: Cleanup race between circuit close and free with the HS circuitmap

[Tor Bug Tracker & Wiki]

#23603: hs: Cleanup race between circuit close and free with the HS circuitmap
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  dgoulet
     Type:  defect        |         Status:  accepted
 Priority:  High          |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by asn):

 Agreed on only doing cleanup in `cleanup_intro_points()`.

 Not sure about the `circuit_retries` counter situation. A real hibernation
 callback is probably not easy to do in a cross-platform way, and resetting
 the retries count is a recipe for guard discovery attacks. However, IIUC
 this bug is not as impotant as the cleanup issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23603#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online