[tor-bugs] #16010 [Applications/Tor Browser]: Get a working content process sandbox for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#16010: Get a working content process sandbox for Tor Browser on Windows
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-security,    |  Actual Points:
  GeorgKoppen201709, TorBrowserTeam201709R       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:60 mcs]:
 > Kathy and I reviewed the proposed changes. They seem fine although we
 admit that we do not understand this stuff very well. We do have a couple
 of questions about the "Bug 16010: Fixing sandbox compile issues" patch:
 >
 > 1. For
 security/sandbox/chromium/sandbox/win/src/sidestep/mini_disassembler_types.h:
 is there a missing `int` in the declaration of `flag_aux_`? This probably
 does not matter because types default to `int` anyway.

 I think you are right, good catch. I'll make a fixup for that.

 > 2. For security/sandbox/chromium/sandbox/win/src/sidestep_resolver.cc:
 do we know what the implications are for the FIXME (making
 `SmartSidestepResolverThunk::SmartStub()` a NOOP)?

 I trust bobowen when he says this one does not get used right now:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1230910#c28. So, we should be
 fine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16010#comment:61>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online