[tor-bugs] #23607 [Core Tor/Tor]: Avoid assertion failure for state file clock skew (was: control_event_bootstrap_problem() should ignore "early" problems instead of asserting)

[Tor Bug Tracker & Wiki]

#23607: Avoid assertion failure for state file clock skew
---------------------------------------------+-----------------------------
 Reporter:  catalyst                         |          Owner:  catalyst
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.3.2.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  bootstrap clock-skew regression  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by catalyst):

 * keywords:   => bootstrap clock-skew regression


Old description:

> The `clock_skew_warning()` refactoring can allow calls to
> `control_event_bootstrap_problem()` prior to bootstrap phase 0, causing
> an assertion failure.  (Clock skew in a state file is one possibility.)
> Instead of asserting, ignore such calls, because they seem to always have
> another logging path.

New description:

 The `clock_skew_warning()` refactoring can cause an assertion failure when
 `or_state_load()` calls to `control_event_bootstrap_problem()` (via
 `clock_skew_warning()` prior to bootstrap phase 0.

 We should initialize the bootstrap state first.

--

Comment:

 Adjust description to match the narrower scope of the fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23607#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online