[tor-bugs] #23420 [Core Tor/Tor]: prop224: Pad RENDEZVOUS1 cell to match legacy cell length

[Tor Bug Tracker & Wiki]

#23420: prop224: Pad RENDEZVOUS1 cell to match legacy cell length
--------------------------------------------+------------------------------
 Reporter:  asn                             |          Owner:  dgoulet
     Type:  defect                          |         Status:  needs_review
 Priority:  Medium                          |      Milestone:  Tor:
                                            |  0.3.2.x-final
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  prop224, prop224-extra, tor-hs  |  Actual Points:
Parent ID:                                  |         Points:  1
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by dgoulet):

 The padding is very cheap to do although I think the current code takes
 the raw bytes from our PRNG so we might not want to expose that to the RP
 directly? The `crypto_strongest_rand()` is the one hashing the bytes but
 could be heavier?

 Considering the padding will in most cases pass the test, seems a win-win
 to just do it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23420#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online