[tor-bugs] #23573 [Core Tor/Tor]: Do we want to close all connections when tor closes?

[Tor Bug Tracker & Wiki]

#23573: Do we want to close all connections when tor closes?
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  shutdown, privcount, correctness,    |  Actual Points:
  chutney-wants                                  |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * keywords:  shutdown, privcount => shutdown, privcount, correctness,
     chutney-wants


Comment:

 My ticket23573 branch has some draft code that implements this issue.
 It also has the `sleep(1);` that fixes #23570.

 If we want to add these checks that our connection shutdown code works, I
 can revise it and write a changes file. It would be useful for chutney,
 which doesn't rotate connections in the short time it's running a network.

 Or we can just let the OS do the connection cleanup for us.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23573#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online