[tor-bugs] #22891 [Core Tor/Tor]: Add GitLab CI configs
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Sep 15 16:20:32 UTC 2017
#22891: Add GitLab CI configs
-------------------------------------------------+-------------------------
Reporter: catalyst | Owner: hiro
Type: defect | Status:
| needs_review
Priority: High | Milestone: Tor:
| 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ci, continuous-integration, | Actual Points:
testing, best-practice, unit-testing, new- |
developers, review-group-22, review-group-23 |
Parent ID: | Points:
Reviewer: ahf, dgoulet | Sponsor:
-------------------------------------------------+-------------------------
Comment (by dgoulet):
Looks reasonable to me!
I'm not very familiar with what this implies: `ssh-add <(echo
"$DEPLOY_KEY")` that is I doubt anyone can just control that env variable?
Giving commit access to network/tor.git to anyone would be bad :S...
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22891#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list