[tor-bugs] #23502 [Core Tor/Tor]: prop224: Don't make IPv4 mandatory because one day we'll have IPv6 only relays

[Tor Bug Tracker & Wiki]

#23502: prop224: Don't make IPv4 mandatory because one day we'll have IPv6 only
relays
----------------------------------------+----------------------------------
 Reporter:  dgoulet                     |          Owner:  dgoulet
     Type:  defect                      |         Status:  merge_ready
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.2.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  prop224, tor-relay, tor-hs  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:  asn                         |        Sponsor:
----------------------------------------+----------------------------------

Comment (by teor):

 The spec seems sensible, and the fix to the code looks correct.

 I think this is a good idea, because it will also make it possible to use
 the common link specifier code to connect to IPv6-only bridges in future.

 Before we merge this, I want to make sure we understand the IPv6 single
 onion bug in #23493. The current code should provide IPv4 for all relays,
 even if we connect to them over IPv6. (If we fix #23493 by ignoring
 missing IPv4 in descriptors and INTRODUCE cells, that's the wrong fix. The
 right fix is to provide both addresses if we know both for the relay.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23502#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online