[tor-bugs] #20168 [Core Tor/Tor]: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Sep 12 14:11:34 UTC 2017
#20168: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif
------------------------------------------+--------------------------------
Reporter: dgoulet | Owner: cjb
Type: enhancement | Status: needs_revision
Priority: Very Low | Milestone: Tor:
| 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Trivial | Resolution:
Keywords: easy, lorax, review-group-23 | Actual Points: .1
Parent ID: | Points:
Reviewer: | Sponsor:
------------------------------------------+--------------------------------
Changes (by dgoulet):
* status: needs_review => needs_revision
Comment:
May I request a change, I know it's super nitpick but it's a personal
preferences that we use `/* ... */` instead of the `//` ?
Another thing, seems that top level ifdef are working with the script but
not the one inside. If I take `statefile.h` for instance, `#ifdef
STATEFILE_PRIVATE` its `#endif` doesn't the annotation. Bug or on purpose?
Which is weird because I see other file correctly annotated...
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20168#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list