[tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

[Tor Bug Tracker & Wiki]

#23355: prop224: Implement a client purge state for NEWNYM
-----------------------------+------------------------------------
 Reporter:  dgoulet          |          Owner:  (none)
     Type:  enhancement      |         Status:  merge_ready
 Priority:  High             |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:  #23300           |         Points:
 Reviewer:  asn              |        Sponsor:
-----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 These maps are caches initialized by `hs_cache_init()` which is called by
 `hs_init()` in `tor_init()`.

 If they are NULL, tor is in a really really bad shape. I think there are
 some levels of confidence we can accept here that is assuming they won't
 be NULL. Else, our entire testing process is badly flawed if we can't
 notice an unallocated cache and nothing segfaulted? :)

 Because to that extent, we have a LOT of callsite that assume that what is
 initialized in init() functions are safe to use at runtime (just see
 `rendcache.c` and friends).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23355#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online