[tor-bugs] #22342 [Core Tor/Tor]: Add a nice append-only stringbuffer, and refactor code to use it
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Oct 31 23:30:47 UTC 2017
#22342: Add a nice append-only stringbuffer, and refactor code to use it
-----------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: review-group-24 | Actual Points: .2
Parent ID: | Points:
Reviewer: isis | Sponsor:
-----------------------------+------------------------------------
Changes (by isis):
* status: needs_review => merge_ready
Comment:
In commit 68a90d09 you've got a docstring where you're doing the thing
where you start a sentence and then I'm not sure what hap
{{{
/** Add a nul-terminated <b>string</b> to <b>buf</b>, but */
}}}
Other than that, everything looks great! The new API looks much cleaner,
especially in the directory code. :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22342#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list