[tor-bugs] #23623 [Core Tor/Tor]: hs: Cache current time period number and SRV start time

[Tor Bug Tracker & Wiki]

#23623: hs: Cache current time period number and SRV start time
-------------------------------------+------------------------------------
 Reporter:  dgoulet                  |          Owner:  dgoulet
     Type:  enhancement              |         Status:  needs_review
 Priority:  Medium                   |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  tor-hs, tor-sr, prop224  |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  asn                      |        Sponsor:
-------------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  accepted => needs_review
 * reviewer:   => asn


Comment:

 It was actually more straight forward than I thought.

 Instead of keeping a star time of current round and time period and what
 not, we actually don't need to do such a thing but rather use the voting
 schedule static object instead. It is updated everytime we get a new
 consensus so using it is as close as we get to the latest.

 Thus, now the SR subsystem only uses that object to compute it stuff.

 Unit test is broken because we have an issue of timestamp being off
 because one function used to take a timestamp "now" but now it only uses
 the voting schedule timings so it needs to be fixed. However, I want to
 know if the approach seems sensible before going further.

 See branch: `ticket23623_032_01`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23623#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online