[tor-bugs] #23016 [Applications/Tor Browser]: "Print to File" does not create the expected file in non-English locales

[Tor Bug Tracker & Wiki]

#23016: "Print to File" does not create the expected file in non-English locales
-------------------------------------------------+-------------------------
 Reporter:  intrigeri                            |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-7.0-issues, tbb-   |  Actual Points:
  regression, tbb-e10s                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by pospeselr):

 Ultimate source of the problem is that nsLocaleService constructor is not
 honoring the javascript.use_us_english_locale flag.  I've a solution in
 mind, but will have to verify it doesn't break Windows and OSX.  Look for
 a patch tomorrow.

 A couple of other places also call setlocale(FOO, "") which sets the
 process's locale to the system locale, which is subsequently undone by the
 OverrideDefaultLocaleIfNeeded() function during startup:
 * nsNativeCharsetUtils
 * XPCOMInit

 Another side-note/observation regarding localization: shouldn't we be
 setting the locale based off of the Tor Browser version (assuming the
 use_us_english_locale flag is not set) rather than the OS defaults?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23016#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online