[tor-bugs] #24002 [Core Tor/Tor]: Check for ed25519 key is inverted in pick_intro_point()

[Tor Bug Tracker & Wiki]

#24002: Check for ed25519 key is inverted in pick_intro_point()
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.2.1-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  prop224       |  Actual Points:
Parent ID:  #23493        |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_information => new
 * parent:   => #23493


Comment:

 Ok, then what we need in 0.3.2 is:
 * a comment that explains why we check for missing keys when nodes don't
 support ed25519
 * a comment that explains why we don't also check for keys being present
 when nodes do support ed25519 (if you're convinced this works, a BUG()
 warning would be a useful defence in depth)

 Since we plan on changing this code in 0.3.3 to avoid using extend infos
 (#23576), I don't think we can rely on the checks in
 extend_info_from_node() in 0.3.3. So we can move the code changes in this
 ticket to 0.3.3 if you want.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24002#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online