[tor-bugs] #24000 [Core Tor/Tor]: circuit_send_intermediate_onion_skin() and extend_cell_format() should check for IPv6

[Tor Bug Tracker & Wiki]

#24000: circuit_send_intermediate_onion_skin() and extend_cell_format() should
check for IPv6
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  ipv6
Actual Points:                |  Parent ID:
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 When circuit_send_intermediate_onion_skin() and extend_cell_format()
 handle tor_addr_t, they assume they are IPv4.

 But in #23502, we almost wrote code that sent them an IPv6 address. In
 this case, they put 0.0.0.0 in the extend cell, but they could issue a
 BUG() warning and refuse to send the cell instead.

 Or they could send a proper IPv6 link specifier where the extend cell
 allows it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24000>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online