[tor-bugs] #23523 [Core Tor/Tor]: Handle extreme values better in add_laplace_noise()

[Tor Bug Tracker & Wiki]

#23523: Handle extreme values better in add_laplace_noise()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.6.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, privcount, review-        |  Actual Points:
  group-24                                       |
Parent ID:  #23061                               |         Points:  0.5
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorQ
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Please see the fixups in my bug23523 branch, they:
 * re-format a comment for style and line length, and remove a unicode
 character
 * expand the comments on the new functions, use the correct integer type,
 and handle unusually large mantissa lengths
 * add a missing semicolon

 I would recommend catalyst as a reviewer, they are good with fiddly math.
 Or maybe isis?
 (I am looking forward to a future where we can write code like this in a
 language that does its own integer checks, and has built-in saturating
 arithmetic functions.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23523#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online