[tor-bugs] #20549 [Metrics/CollecTor]: Implement SanitizedBridgeServerDescriptor class that encapsulates the sanitizing logic for bridge server descriptors
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Oct 25 19:15:47 UTC 2017
#20549: Implement SanitizedBridgeServerDescriptor class that encapsulates the
sanitizing logic for bridge server descriptors
-------------------------------+------------------------------
Reporter: iwakeh | Owner: metrics-team
Type: enhancement | Status: assigned
Priority: Medium | Milestone:
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: metrics-2017 | Actual Points:
Parent ID: #20542 | Points:
Reviewer: | Sponsor:
-------------------------------+------------------------------
Changes (by karsten):
* keywords: metrics-2018 => metrics-2017
Comment:
Replying to [comment:4 iwakeh]:
> Also pay attention to the issues mentioned in #23981's comments.
Right. In particular, I'd like to try out the following change that I
suggested on that ticket:
"While working on this patch I considered taking a different approach
where we'd include placeholders for parts that we cannot sanitize yet and
fill them in after finishing to read the original descriptor. This could
be a `List<StringBuilder>` to retain order of original lines and where
we'd keep references to some `StringBuilder`s that we need to sanitize
after reading. Still something to think about. Let's do that after fixing
this ugly bug."
> Shouldn't this be moved to metrics-2017?
Sure. Worth trying.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20549#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list