[tor-bugs] #23844 [Metrics/ExoneraTor]: Fix NullPointerException thrown by providing invalid parameters

[Tor Bug Tracker & Wiki]

#23844: Fix NullPointerException thrown by providing invalid parameters
--------------------------------+--------------------------
 Reporter:  karsten             |          Owner:  karsten
     Type:  defect              |         Status:  accepted
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+--------------------------
Changes (by karsten):

 * owner:  metrics-team => karsten
 * status:  needs_review => accepted


Comment:

 Thanks for analyzing this bug! I applied a slightly different change that
 is closer to what we previously did. In fact, with the current code
 (before my change) we were writing to a closed output stream, which we
 shouldn't do.

 I deployed the fix.

 However, we now say that we couldn't connect to the database (= backend)
 when in fact we didn't even attempt to connect, because we didn't receive
 valid parameters. Should be an easy fix which I'll make after lunch. At
 least the exception is gone now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23844#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online