[tor-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

[Tor Bug Tracker & Wiki]

#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by cypherpunks):

 Let's assume NoScript was updated to 5.1.2 on gk's Tor Browser, and he
 will come to say some words here :)

 Replying to ma1:
 > > > Update: it seems `[System+Principal]` doesn't work.
 > >
 > > Work at what? The message about [System Principal] just takes note
 that there was a window where scripts could not be blocked because it had
 chrome privileges. It's normal, and nothing that needs to be "fixed".
 > That whitelist item doesn't suppress those messages.
 `this.mandatorySites.sitesString = this.getPref("mandatory", "chrome:
 about: resource: [System Principal]");` in Main.js seems to use " " as the
 pref does, so it works in the default NS config, but doesn't work if added
 manually with "+" sign.
 Also shouldn't it contain `moz-extension:`? Maybe, it could fix #23322.
 Candidate for whitelisting is #23736.

 As for restartless updates, the correct documentation seems to be
 https://dxr.mozilla.org/mozilla-
 esr52/rev/efa03deffad75f19fc598a757239e99b22a8bceb/toolkit/mozapps/extensions/internal/XPIProvider.jsm#4865
 as usual :( But some links from https://developer.mozilla.org/en-US/Add-
 ons/Bootstrapped_extensions are also useful and could be used for
 bootstrapped part refactoring in order to get the dialog box when
 disabling NoScript working, for example.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online