[tor-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

[Tor Bug Tracker & Wiki]

#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by cypherpunks):

 Replying to [comment:28 ma1]:
 > Replying to [comment:27 cypherpunks]:
 >
 >
 > > Replying to [comment:26 ma1]:
 > > Hi, Giorgio.
 > > Unfortunately, not all issues with the Security Slider were resolved.
 The last one is that `NoScript preferences backup on the WebExtension
 side` doesn't happen right after updating NoScript settings by the
 Torbutton.
 >
 > It does on startup, shutdown and every type the NoScript Service's
 savePrefs() method is called.
 >
 > It's meant to just backup the configuration, and should have no visible
 impact on how NoScript 5.x actually behaves. So, no "weird effects" from
 this are plausible.
 >
 > > This has weird effects, e.g. videos play automatically on Low, but
 under the rectangle of blocked video, and NoScript icon and menu show that
 the video was blocked (left from the previously selected Medium level).
 >
 > See above. Please file a separate bug if you can consistently reproduce.
 Hmm. Then it could be a restartless update issue (Set Security Slider to
 Medium before update).
 > > >
 > > {{{
 > > 17:21:54.970 1507742514900        addons.xpi        ERROR
 Failed to remove file C:\Tor
 Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\trash\{73a6fe31
 -595d-460b-a920-fcc0f8843232}.xpi: [Exception... "Component returned
 failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"
 nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame
 :: resource://gre/modules/addons/XPIProvider.jsm :: recursiveRemove ::
 line 2005"  data: no] ![...]
 > > This is an `ERROR` exactly and should be fixed.
 >
 > If you think it actually is, you should file a bug in Mozilla's Bugzilla
 tracker, Toolkit>Add-ons Manager component.
 Mozilla thinks. And we are not happy with a leftover in trash on disk.
 > > Addons should wait until manifest is registered by Firefox. This is
 critical.
 >
 > Or, it might just be something not expecting NoScript to be uninstalled
 without a browser restart. Can you point out actual user-affecting issues
 directly caused by to this? If so, please file separate bugs.
 If random icon disappearing is not enough, then...
 >
 > > > {{{
 > > 1507747660900        addons.xpi        DEBUG        Calling bootstrap
 method startup on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc5
 > > 1507747661000        DeferredSave.extensions.json        DEBUG
 Starting timer
 > > 1507747661000        addons.xpi        DEBUG
 removeTemporaryFile: https://addons.mozilla.org/firefox/downloads/latest-
 beta/noscript/addon-722-latest.xpi?src=search removing temp file
 C:\Users\X\AppData\Local\Temp\tmp-2sv.xpi
 > > No matching message handler for the given recipient.
 MessageChannel.jsm:621
 > > }}}
 > > So, this happens in exact place during addon's startup.
 >
 > "This" what?
 This error in MessageChannel.jsm
 > > Now we have
 > > {{{
 > > 1507740751000        addons.webextension.<unknown>        WARN
 Loading extension 'null': Reading manifest: Error processing
 permissions.1: Unknown permission "privacy"
 > > 1507740751000        addons.webextension.<unknown>        WARN
 Loading extension 'null': Reading manifest: Error processing
 permissions.4: Unknown permission "unlimitedStorage"
 > > 1507740751800        addons.webextension.{73a6fe31-595d-
 460b-a920-fcc0f8843232}        WARN        Loading extension '{73a6fe31
 -595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing
 permissions.1: Unknown permission "privacy"
 > > 1507740751800        addons.webextension.{73a6fe31-595d-
 460b-a920-fcc0f8843232}        WARN        Loading extension '{73a6fe31
 -595d-460b-a920-fcc0f8843232}': Reading manifest: Error processing
 permissions.4: Unknown permission "unlimitedStorage"
 > > }}}
 > > and
 > > {{{
 > > noscript-tbb not found!
 > > [10-11 17:02:22] Torbutton INFO: New window
 > > }}}
 > > which is an exclamation about the obvious thing :)
 >
 > ... none of which is a bug, despite the exclamation mark.
 The exclamation is not a bug. NoScript's `extension 'null'` - it's not so
 obvious.
 > >
 > > Update: it seems `[System+Principal]` doesn't work.
 >
 > Work at what? The message about [System Principal] just takes note that
 there was a window where scripts could not be blocked because it had
 chrome privileges. It's normal, and nothing that needs to be "fixed".
 That whitelist item doesn't suppress those messages.
 > Suggestion: please set the "noscript.consoleDump" preference to 0. If
 anything '''actually''' abnormal happens, you'll get messages in the
 browser console anyway.
 Already set.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online