[tor-bugs] #23114 [Core Tor/Tor]: Circuit Build Timeout should apply at circuit completion

[Tor Bug Tracker & Wiki]

#23114: Circuit Build Timeout should apply at circuit completion
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  guard-discovery-prop247-controller,  |  Actual Points:
  review-group-25, review-group-26               |
Parent ID:  #23100                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 I added the comment and the consts in
 7ecc6ebcc2d58fd49ece7a4478a5b0eee0a97c37.

 I don't think that bending over backwards to propagate first_hop_succeded
 is an improvement. The variable is basically an alias for the first cpath
 being STATE_OPENED. This serves as a clarifying comment rather than than
 an optimization or abstraction. Trying to propagate the result a long way
 will be both less clear and more error prone, and doesn't save us anything
 that the compiler wouldn't optimize anyway.

 Nick has previously said that he prefers to squash things himself, so I'm
 just going to leave mikeperry/bug23114 unsquashed for now until we hear
 from him. That way he can also decide if he wants the refactoring commit
 (90b29f1cc56a2402d00373043748eb198815d9a4) to be squashed into Bug #23100
 or kept separate in the final merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23114#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online