[tor-bugs] #24419 [Metrics/Onionoo]: Improve getter names for boolean fields

Mon Nov 27 09:24:57 UTC 2017

#24419: Improve getter names for boolean fields
---------------------------------+--------------------------
     Reporter:  karsten          |      Owner:  metrics-team
         Type:  enhancement      |     Status:  new
     Priority:  Medium           |  Milestone:
    Component:  Metrics/Onionoo  |    Version:
     Severity:  Normal           |   Keywords:
Actual Points:                   |  Parent ID:
       Points:                   |   Reviewer:
      Sponsor:                   |
---------------------------------+--------------------------
 From #21827:

 > The method name `getRecommendedVersion` is quite misleading - especially
 together with `getVersion` - as it returns a boolean not a version value,
 but as the method was introduced long ago this shouldn't halt a merge.
 >
 > Maybe, the naming could be improved at some point?

 So, what should we rename here? All `boolean`/`Boolean` fields in `docs`
 package classes to `isXY()`?

 Anything else?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24419>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online