[tor-bugs] #23681 [Core Tor/Tor]: prop224: Clients mark intro circs as timed-out within seconds

[Tor Bug Tracker & Wiki]

#23681: prop224: Clients mark intro circs as timed-out within seconds
-----------------------------+------------------------------------
 Reporter:  asn              |          Owner:  dgoulet
     Type:  defect           |         Status:  needs_revision
 Priority:  High             |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  mikeperry        |        Sponsor:
-----------------------------+------------------------------------
Changes (by mikeperry):

 * status:  needs_review => needs_revision


Comment:

 Code-wise this looks good. These intro circs still should be given longer
 than normal since they have 4 hops, but there is a case for that.

 The changes file has a little wonky phrasing though. Instead of "The
 introduction circuit was timeout very fast while waiting" I would say "The
 introduction circuit was being timed out too quickly while waiting".

 Other than that, this all looks good. Did you verify the idle timeout
 applies to intro circs? Maybe try to connect to a hidden service that has
 rend circuit building commented out so it rends don't complete?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23681#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online