[tor-bugs] #24119 [Core Tor/Tor]: channel_rsa_id_group_set_badness spends a lot of time in malloc/free

[Tor Bug Tracker & Wiki]

#24119: channel_rsa_id_group_set_badness spends a lot of time in malloc/free
-------------------------------------------------+-------------------------
 Reporter:  Hello71                              |          Owner:  Hello71
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  tor-channel, tor-sched,              |  Actual Points:
  032-backport, review-group-25                  |
Parent ID:  #23777                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by Hello71):

 https://cgit.alxu.ca/tor.git/log/?h=bug24119 resolves the problems. I
 don't know if you agree about fast_memcmp here, but there seem to be
 similar uses in other sorting helpers. also I dunno about the underscore
 here, because this part seems to already be back and forth between
 connections and channels.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24119#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online