[tor-bugs] #10394 [Applications/Tor Browser]: Torbrowser's updater updates HTTPS-everywhere

[Tor Bug Tracker & Wiki]

#10394: Torbrowser's updater updates HTTPS-everywhere
------------------------------------------------+--------------------------
 Reporter:  StrangeCharm                        |          Owner:  tbb-team
     Type:  task                                |         Status:  reopened
 Priority:  Medium                              |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------
Changes (by gk):

 * status:  closed => reopened
 * keywords:  tbb-security, TorBrowserTeam201711R => tbb-security,
     TorBrowserTeam201711
 * resolution:  fixed =>
 * cc: legind (added)


Comment:

 Firefox does not like our trick in a WebExtensions context:
 {{{
 1510514437300   addons.webextension.<unknown>   ERROR   Loading extension
 'null': Reading manifest: Error processing applications.gecko.update_url:
 Error: Access denied for URL data:text/plain,
 1510514437500   addons.xpi-utils        WARN    updateMetadata: Add-on
 https-everywhere-eff at eff.org is invalid: Error: Extension is invalid
 (resource://gre/modules/addons/XPIProvider.jsm:963:11) JS Stack trace:
 loadManifestFromWebManifest<@XPIProvider.jsm:963:11 <
 TaskImpl_run at Task.jsm:319:42 < Handler.prototype.process at Promise-
 backend.js:932:23 < this.PromiseWalker.walkerLoop at Promise-backend.js:813:7
 < this.PromiseWalker.scheduleWalkerLoop/<@Promise-backend.js:747:11 <
 syncLoadManifestFromFile at XPIProvider.jsm:1621:5 <
 updateMetadata at XPIProviderUtils.js:1785:21 <
 processFileChanges at XPIProviderUtils.js:2009:26 <
 this.XPIProvider.checkForChanges at XPIProvider.jsm:3899:34 <
 this.XPIProvider.startup at XPIProvider.jsm:2839:25 <
 callProvider at AddonManager.jsm:242:12 <
 _startProvider at AddonManager.jsm:795:5 <
 AddonManagerInternal.startup at AddonManager.jsm:1005:9 <
 this.AddonManagerPrivate.startup at AddonManager.jsm:3062:5 <
 amManager.prototype.observe at addonManager.js:65:9
 }}}
 So, we need something better and need to rebuild the alphas.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10394#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online