[tor-bugs] #24174 [Metrics/ExoneraTor]: Use an embedded Jetty in ExoneraTor

[Tor Bug Tracker & Wiki]

#24174: Use an embedded Jetty in ExoneraTor
--------------------------------+------------------------------
 Reporter:  iwakeh              |          Owner:  iwakeh
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  metrics-2017        |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:5 iwakeh]:
 > The additional dependencies are not such a problematic thing.  Simply
 tomcat embedded for jsps plus the eclipse compiler.  All available as
 debian packages.

 Different question then: if we need to include parts of embedded Tomcat,
 why don't we switch to that entirely? It's the embedded part that we're
 after, right? Or what else do we gain from picking Jetty in particular?

 > Here the package listing:
 > libasm-java (5.2-2)
 > libtomcat8-embed-java (8.5.14-1+deb9u2)
 > libecj-java (3.11.1-1)

 Okay, that's good to know.

 > Most other technologies won't have less dependencies.

 Yeah, good point.

 > BTW, the tweaked jar only prevents a duplicate include of a service
 definiton that wouldn't cause harm, so a rather picky measurement.

 I don't fully understand the benefit from preventing this duplicate. Can
 you explain that? To be honest, I'd feel much more comfortable with a
 build process that doesn't "tweak" provided library files. It feels
 fragile.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24174#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online