[tor-bugs] #12062 [Core Tor/Tor]: Audit DisableNetwork, we_are_hibernating usage

[Tor Bug Tracker & Wiki]

#12062: Audit DisableNetwork, we_are_hibernating usage
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client, technical-debt, quiet-   |  Actual Points:
  mode, sponsor8-maybe, review-group-24          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 I think the code added to `should_delay_dir_fetches()` is missing a
 "return 1".

 The rest lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12062#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online