[tor-bugs] #23577 [Core Tor/Tor]: Add rendezvous point IPv6 address to client introduce cells (was: Make setup_introduce1_data() take a node instead of an extend_info)

[Tor Bug Tracker & Wiki]

#23577: Add rendezvous point IPv6 address to client introduce cells
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  2
Parent ID:  #23493                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => merge_ready
 * type:  defect => enhancement
 * version:  Tor: 0.3.2.1-alpha =>
 * actualpoints:  1 => 2


Comment:

 My branch bug23577 at https://github.com/teor2345/tor.git has neel's
 changes rebased to the latest master, and fixup / squash commits that:
 * Fix "make check-spaces" errors
 * Check that the IPv4 address is valid before adding any link specifiers
 * Edit some comments to match the new code
 * Summarise the changes file (we usually use one entry per change)

 It passes "make check" and "make test-network-all".

 It is safe to merge to master, because 0.3.2 services ignore IPv6 link
 specifiers in client introduce cells.

 I have opened these follow-up tickets:
 * #24193 for v3 single onion services to use IPv6 addresses (0.3.3), and
 * #24181 for v3 onion services to put unrecognised link specifiers
 (including IPv6) into EXTEND cells (can be longer term)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23577#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online