[tor-bugs] #23623 [Core Tor/Tor]: hs: Cache current time period number and SRV start time

[Tor Bug Tracker & Wiki]

#23623: hs: Cache current time period number and SRV start time
-------------------------------------+------------------------------------
 Reporter:  dgoulet                  |          Owner:  dgoulet
     Type:  enhancement              |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  tor-hs, tor-sr, prop224  |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  asn                      |        Sponsor:
-------------------------------------+------------------------------------

Comment (by dgoulet):

 Before that patch, the function `get_next_valid_after_time(time_t now)`,
 which was renamed in this patch to
 `dirvote_get_next_valid_after_time(void)`, was allocating a voting
 schedule using `now` and returning the `voting_schedule.interval_starts`
 of that newly created schedule.

 We now use a static voting schedule and update it with
 `dirvote_recalculate_timing()`, the test became pointless because that
 function now only returns `interval_starts` which is from the static
 voting schedule. Thus it is not needed as the test have been modified to
 use a static object and update it as it goes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23623#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online