[tor-bugs] #22408 [- Select a component]: Refactor functions over 300 lines long.

[Tor Bug Tracker & Wiki]

#22408: Refactor functions over 300 lines long.
-------------------------------------------------+-------------------------
     Reporter:  nickm                            |      Owner:
         Type:  defect                           |     Status:  new
     Priority:  Medium                           |  Milestone:  Tor:
                                                 |  0.3.2.x-final
    Component:  - Select a component             |    Version:
     Severity:  Normal                           |   Keywords:
Actual Points:  technical-debt refactor long-    |  Parent ID:  #6313
  functions cthulhucode                          |
       Points:  5                                |   Reviewer:
      Sponsor:                                   |
-------------------------------------------------+-------------------------
 I think it's reasonable to impose a much smaller limit, but let's start by
 attacking the worst offenders.  cc'ing catalyst because we've talked about
 this before.

 It's probably a good idea to use a separate ticket or separate branch for
 each one.

 {{{
 300 connection_listener_new
 306 networkstatus_set_current_consensus
 327 rend_service_receive_introduction
 330 ed_key_init_from_file
 332 circuit_get_open_circ_or_launch
 355 tor_spawn_background
 360 router_dump_router_to_string
 389 networkstatus_verify_bw_weights
 389 parse_socks
 399 connection_edge_process_relay_cell
 404 circuit_expire_building
 449 parse_port_config
 535 options_act
 541 connection_ap_handshake_rewrite_and_attach
 548 router_parse_entry_from_string
 638 networkstatus_parse_vote_from_string
 973 networkstatus_compute_consensus
 1269 options_validate
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22408>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online