[tor-bugs] #22301 [Core Tor/Stem]: make test-stem doesn't work

[Tor Bug Tracker & Wiki]

#22301: make test-stem doesn't work
---------------------------+------------------------------------
 Reporter:  catalyst       |          Owner:  atagar
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Stem  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------------

Comment (by atagar):

 > make test-stem (and thus make test-full) still fails from the top of the
 tor source tree

 Gotcha. I tried running the tests from various relative paths when making
 these patches but couldn't repro the issue...

 {{{
 % env -i ./stem/run_tests.py --all --tor tor/tor/src/or/tor
 % env -i ../run_tests.py --all --tor ../../tor/tor/src/or/tor
 }}}

 Maybe a bug with the make target rather than stem?

 > ... expects its working directory to be the top of the stem source tree
 and not anywhere else

 Hmmm, the test calls os.chdir() in an effort to avoid these issues...

 https://gitweb.torproject.org/stem.git/tree/test/integ/installation.py#n34

 Are you able to come up with a repro invoking run_tests.py directly rather
 than tor's make target?

 > Not having a system tor installed might be unusual but I think we should
 support that use case.

 Absolutely agreed, and this is a miss on my side. Puzzled though. I'm
 expecting the 'env -i' to allow me to repro this...

 > I'm sorry if I misspoke about the $PATH issue. I meant that I don't have
 a tor binary installed on this system, and somehow the tests were trying
 to look for a tor binary in my $PATH, not that I had an empty or missing
 $PATH environment variable.

 Oh no, you didn't misspeak. I'm dropping my PATH in an effort to repro the
 issue you mentioned. That's all.

 > I think I will make separate child tickets because these issues are
 partially separable.

 Sounds good!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22301#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online