[tor-bugs] #22307 [Metrics/Atlas]: Atlas shows duplicates shown when a bridge changes to a publicly listed node.

[Tor Bug Tracker & Wiki]

#22307: Atlas shows duplicates shown when a bridge changes to a publicly listed
node.
---------------------------+--------------------------------
 Reporter:  entry          |          Owner:  metrics-team
     Type:  defect         |         Status:  needs_revision
 Priority:  Very Low       |      Milestone:
Component:  Metrics/Atlas  |        Version:
 Severity:  Trivial        |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+--------------------------------

Comment (by cypherpunks):

 Replying to [comment:7 cypherpunks]:
 > The patch fixes the issue on the search page but the results link to the
 incorrect details page. Please ignore the patch for now.
 The results do '''not''' link to the incorrect details pages. It is Atlas
 always using hashed fingerprints for Onionoo requests which does not work
 with the fingerprint parameter. Atlas hashes the given fingerprints to
 prevent bridge fingerprints from being leaked but in this case it prevents
 searches for exact matches.

 ~~I'm unsure about how to continue now. On one hand we want exact matches
 (especially for the details page because it presents information about a
 specific relay or bridge) which means we should pass on the exact
 fingerprint the user gives us. On the other hand we want to protect the
 user from leaking bridge fingerprints which forces us to use the lookup
 parameter which can return multiple results with no good way to select one
 of the results.~~

 Thinking about it some more i believe the solution is to rehash the
 fingerprints Onionoo returns in the summary response. This will turn the
 details requests using the lookup parameter into

 https://onionoo.torproject.org/details?lookup=D752CBAB72003DE7774D032186A47ACE09CD27C1
 for the relay.
 https://onionoo.torproject.org/details?lookup=BD2734E77BEBA086B9718091B6D11A75422E4770
 for the bridge.

 The first request returns both relay and bridge where Atlas will only
 parse the relay as explained in comment:4. The second request returns only
 the bridge so Atlas can and will only parse the bridge.

 This solution was discussed previously in #21615 in a different context
 but was closed as `not a bug`. Now it turns out it is a bug so i'll reopen
 and make this ticket the parent.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22307#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online